DAOS-19513 ddb: extend SPDK re-init guard to all NVMe devices - #18962
Draft
knard38 wants to merge 1 commit into
Draft
DAOS-19513 ddb: extend SPDK re-init guard to all NVMe devices#18962knard38 wants to merge 1 commit into
knard38 wants to merge 1 commit into
Conversation
DAOS-18597 (PR #17838)'s guard against a crash-prone second in-process SPDK/VOS init only applied when VMD was involved, but the same SPDK re-init limitation affects any NVMe-backed pool. Generalize the guard (ddb_vmd_wa.c/vmd_wa_can_proceed() becomes ddb_spdk_reinit_wa.c/spdk_reinit_wa_can_proceed()) to cover all NVMe-backed pools, and move every call site into ddb_vos.c next to the vos_self_init() call it protects. This also fixes dv_pool_open() checking the guard against the wrong db_path when --db_path was omitted, the common case that reproduced the crash on real hardware. Add a diagnostic-only DAOS_DDB_ALLOW_SPDK_REINIT environment variable (non-release builds) to bypass the guard when validating a newer SPDK/DPDK version. Expand tests to cover the generalized guard and its new call sites, and document the limitation in ddb's README, --help, and man page. Features: recovery Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
|
Ticket title is 'ddb: SPDK re-initialization fails for standard (non-VMD) NVMe devices within a single ddb process' |
knard38
force-pushed
the
ckochhof/fix/master/daos-19513/patch-001
branch
from
August 28, 2026 18:43
397f5c4 to
d844603
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TODO
Steps for the author:
After all prior steps are complete: