Skip to content

DAOS-18988 mercury: add NA UCX patch to fix bulk binding performance issues - #18946

Open
soumagne wants to merge 3 commits into
masterfrom
soumagne/mercury_bulk_bind
Open

DAOS-18988 mercury: add NA UCX patch to fix bulk binding performance issues#18946
soumagne wants to merge 3 commits into
masterfrom
soumagne/mercury_bulk_bind

Conversation

@soumagne

Copy link
Copy Markdown
Collaborator

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

Signed-off-by: Jerome Soumagne <jerome.soumagne@hpe.com>
…issues

Signed-off-by: Jerome Soumagne <jerome.soumagne@hpe.com>
@soumagne
soumagne requested a review from a team as a code owner August 27, 2026 00:36
@soumagne
soumagne requested review from frostedcmos and mchaarawi and removed request for a team August 27, 2026 00:36
@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown

Ticket title is 'Performance degradation and growing memory use by DFS writer'
Status is 'In Review'
Labels: 'scrubbed_2.8'
https://daosio.atlassian.net/browse/DAOS-18988

@soumagne
soumagne requested review from a team and jgmoore-or August 27, 2026 00:37
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Unit Test with memcheck completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18946/2/testReport/

@daosbuild3

Copy link
Copy Markdown
Collaborator

Signed-off-by: Jerome Soumagne <jerome.soumagne@hpe.com>

Priority: 2
@daltonbohning daltonbohning added the release-3.0.0 Targeted for release 3.0.0 label Aug 27, 2026
Comment on lines +615 to +618
+
+ /* Reuse cached address when one already exists for this worker, so that
+ * repeated deserializations do not create a new EP for every operation */
+ if (!na_ucx_addr) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my main concern is this part.
this works fine when it is the same client sending bulks over, so we can re-use this cached entry

what happens when it is a new client which happens to reuse old worker address? are we safe using this entry then or will it result in some host unreachable errors down the line?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified that the entry gets correctly removed on disconnect event

@daosbuild3

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-3.0.0 Targeted for release 3.0.0

Development

Successfully merging this pull request may close these issues.

5 participants