DAOS-19546 rebuild: fix status timestamp lookup - #18925
Open
wangshilong wants to merge 2 commits into
Open
Conversation
rebuild_leader_set_update_time() searches rgt_servers_sorted, which is an array of pointers sorted by rank. The returned index is valid for rgt_servers_sorted, not for the original rgt_servers array. Use rebuild_server_get_status() to get the matching server status before updating last_update. Signed-off-by: Shilong Wang <shilong.wang@hpe.com>
|
Ticket title is 'rebuild_leader_set_update_time() uses incorrect index for rgt_servers array' |
kccain
approved these changes
Aug 25, 2026
liuxuezhao
approved these changes
Aug 26, 2026
Collaborator
|
Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18925/2/execution/node/703/log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebuild_leader_set_update_time() searches rgt_servers_sorted, which is an array of pointers sorted by rank. The returned index is valid for rgt_servers_sorted, not for the original rgt_servers array.
Use rebuild_server_get_status() to get the matching server status before updating last_update.
Steps for the author:
After all prior steps are complete: