Skip to content

Add green normalized difference vegetative index (GNDVI)#1942

Merged
nfahlgren merged 5 commits into
v5.0from
1941-norm-gdvi
Jun 9, 2026
Merged

Add green normalized difference vegetative index (GNDVI)#1942
nfahlgren merged 5 commits into
v5.0from
1941-norm-gdvi

Conversation

@k034b363

@k034b363 k034b363 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Describe your changes
Previously, PlantCV supported calculation of the green difference vegetative index (GDVI), but not its normalized version. This PR adds GNDVI in the list of supported spectral indices, and updates the documentation to accurately describe what is calculated in each.

Type of update

  • Bug fix
  • New feature or feature enhancement

Associated issues
Closes #1941

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@deepsource-io

deepsource-io Bot commented Jun 5, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 10eaa2c...0b3c861 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Jun 8, 2026 4:31p.m. Review ↗
Code coverage Jun 8, 2026 4:31p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
[✓ above threshold]
99.9%
[▼ down 0.1% from main]
Python
100%
[✓ above threshold]
99.9%
[▼ down 0.1% from main]

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@k034b363 k034b363 added the work in progress Mark work in progress label Jun 5, 2026
@k034b363 k034b363 added new feature New feature ideas and solutions bugfix Bug fixes ready to review and removed work in progress Mark work in progress labels Jun 5, 2026
@joshqsumner joshqsumner self-requested a review June 8, 2026 16:28

@joshqsumner joshqsumner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nfahlgren nfahlgren added this to the PlantCV v5.0 milestone Jun 9, 2026
@nfahlgren nfahlgren merged commit ce0b36e into v5.0 Jun 9, 2026
5 checks passed
@nfahlgren nfahlgren deleted the 1941-norm-gdvi branch June 9, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fixes new feature New feature ideas and solutions ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants