Auto recalculate delta e when color correcting#1931
Open
joshqsumner wants to merge 62 commits into
Open
Conversation
 |
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Python |  |
May 29, 2026 7:14p.m. | Review ↗ |
| Code coverage | |
May 29, 2026 7:14p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (New Code) | Line Coverage (Overall) |
|---|---|---|
| Aggregate | 100% [✓ above threshold] |
99.9% [▼ down 0.1% from main] |
| Python | 100% [✓ above threshold] |
99.9% [▼ down 0.1% from main] |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
joshqsumner
added
ready to review
and removed
work in progress
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added a helper function to
plantcv.transformto rerundeltaEcalculation when an image is color corrected if it was run previously (presumably on the uncorrected image). To avoid circular imports this requires a small amount of refactoring forplantcv.transform.color_correctionand an additionalplantcv.params.deltaEattribute that I doubt people will interact with much andplantcv.params.function_argsthat is undocumented and could become a hidden attribute that we use to keep track ofontologyor useful details.Type of update
This is a feature enhancement.
Associated issues
Part of #1910
Additional context
Builds off of changes in PR #1922
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md