Julian/various fixes - #1432
Open
julian-CStack wants to merge 50 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #1432 +/- ##
===========================================
+ Coverage 4.75% 5.69% +0.93%
===========================================
Files 1108 1112 +4
Lines 110815 111293 +478
===========================================
+ Hits 5273 6333 +1060
+ Misses 105542 104960 -582 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sneurlax
reviewed
Aug 20, 2026
| int _calculateRestoreHeightFrom({required DateTime date}) { | ||
| final int secondsSinceEpoch = date.millisecondsSinceEpoch ~/ 1000; | ||
| const int mimblewimblecoinFirstBlock = 1565370278; | ||
| const int mimblewimblecoinFirstBlock = 1573462800; |
Member
There was a problem hiding this comment.
is this the time of block 2265984? would be good to document this as a comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all fixes are contained to a single commit