Repository navigation
fix Pitch.transpose(inPlace) was keeping extra microtones - #2075
Merged
Merged
Conversation
The in-place copy-back took the transposed copy's microtone only when it was not None, so a microtone the transposition removed stayed: C4(+50c) up a ChromaticInterval(0.5) in place gave C#4(+50c), while the transposed copy is C#4. AI-assisted (Claude)
mscuthbert
changed the title
mscuthbert
marked this pull request as ready for review
October 10, 2026 03:10
|
coverage: 93.372%. remained the same — fix-transpose-inplace-microtone into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pitch.transpose(inPlace=True)copied the transposed pitch's microtone back only when it was not None. This meant that a transposition that moved a microtonal accidental back into 12-tone space (like transposing a half-sharp up 0.5 semitones) didn't set .microtone=False.Found during the #2010 speedup work.
AI-assisted (Claude)