Repository navigation
Read lyric print-object="no" as hidden - #2064
Merged
Merged
Conversation
xmlToLyric passed print-object through setStyleAttributes, whose yes/no-to-bool conversion does not invert, so print-object="no" became hideObjectOnPrint = False and "yes" became True. Use setPrintObject, as the exporter already does. Export was correct, so a hidden lyric did not survive a round trip until now. Bump to 11.0.0b11 since cached musicxml parses are wrong. Found while working on the Accidental-creation speedups for #2010. AI-assisted (Claude)
|
coverage: 93.368% (+0.002%) from 93.366% — fix-lyric-print-object into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally AI written as a "side quest" (i still find that metaphor chuckle inducing...almost dead) -- myke review says good -- except for a repeated attribute
Lyric musicxml import did not set hideObjectOnPrint properly from print-object
Found while working on the Accidental-creation speedups for #2010.
AI-assisted (Claude)