🛡️ Sentinel: [security improvement] Redact sensitive credentials and keys in error-reporting utility - #131
Conversation
…keys in error-reporting utility - Implemented recursive `sanitize` function in `app/lib/error-reporting.ts` to redact Vercel Blob tokens (matching `vercel_blob_rw_[a-zA-Z0-9_-]+`) and sensitive properties (e.g. `password`, `secret`, `token`, `key`, `authorization`, `cookie`, `credential`, `apikey`). - Handled built-in objects directly (Date/RegExp) and avoided circular reference stack overflows using a WeakSet. - Added comprehensive unit tests in `tests/unit/lib/error-reporting.test.ts`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🛡️ Sentinel: [security improvement] Redact sensitive credentials and keys in error-reporting utility
💡 Vulnerability/Risk:
Without sanitization, raw errors or context metadata can leak sensitive credentials (such as Vercel Blob read/write tokens, API keys, authorization headers, or passwords) into local console logs or external error logging solutions (like Sentry or Axiom).
🔧 Fix:
sanitizehelper inapp/lib/error-reporting.tsthat strips Vercel Blob tokens matching/vercel_blob_rw_[a-zA-Z0-9_-]+/giand redacts values associated with sensitive keys (e.g., key, secret, password, token, authorization).✅ Verification:
tests/unit/lib/error-reporting.test.tschecking string redaction, object key redaction, Error object cloning/scrubbing, built-in object retention, and circular reference handling.PR created automatically by Jules for task 12971813671919977372 started by @amrabed