Repository navigation
Conversation
|
The latest Buf updates on your PR. Results from workflow CI / buf-lint (pull_request).
|
Coverage Report for CI Build 37787800131Warning No base build found for commit Coverage: 37.589%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
|
Tested, it fixes the softlock 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing
clock.Runlockcalls. Current implementation can lead to softlocks, such that only read operations on challenges are possible in the future. In case oflocallock a reboot is sufficient to fix, yet as it is stateful it is nearly impossible in production ;etcdneeds Ops deleting the locks manually, which suffers from the previous plus the complexity ofetcditself.It also fixes the linting errors that appeared a while ago through a silent update in
golangci-lint, blockingagainthe dependabot PRs.Found by @d3vyce