Skip to content

feat: replace advisory pip-audit with blocking vuln process#6058

Draft
theCyberTech wants to merge 1 commit into
mainfrom
feat/pip-audit-process
Draft

feat: replace advisory pip-audit with blocking vuln process#6058
theCyberTech wants to merge 1 commit into
mainfrom
feat/pip-audit-process

Conversation

@theCyberTech
Copy link
Copy Markdown
Member

What

Replaces the current advisory-only pip-audit workflow with a blocking process that actually enforces the policy.

Current problem

  • continue-on-error: true means the action never blocks anything
  • 15 hardcoded --ignore-vuln entries with no mechanism to check if they're still needed
  • No visibility into whether vulns are direct or transitive

New process

  1. Run pip-audit without ignores — catch everything
  2. Classify as direct or transitive — checks against all monorepo pyproject.toml files
  3. Direct vulns → auto-fix with pip-audit --fix, commit the bump to the PR branch. PR stays blocked if fix fails.
  4. Transitive vulns → add to ignore list, create a GitHub issue tagged security,transitive-vuln for tracking
  5. Re-run pip-audit with transitive ignores — passes only if direct vulns are resolved

What changes

  • Removes continue-on-error: true — the action actually blocks now
  • Removes the 15 hardcoded --ignore-vuln entries — transitive vulns are auto-ignored at runtime
  • Adds direct/transitive classification using all monorepo pyproject.toml files
  • Auto-creates GitHub issues for transitive vulns so they don't silently rot
  • Auto-commits dependency bumps for direct vulns when possible

@mintlify
Copy link
Copy Markdown

mintlify Bot commented Jun 6, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
crewai 🟢 Ready View Preview Jun 6, 2026, 7:46 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 6, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 00c68864-2fed-49b8-81a3-fc4209e3a471

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/pip-audit-process

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

New vulnerability scan process:
1. Run pip-audit without ignores on every PR
2. Classify vulns as direct or transitive (checks against all monorepo pyproject.toml files)
3. Direct vulns: auto-fix with pip-audit --fix and commit the bump to the PR branch
4. Transitive vulns: add to ignore list and create a GitHub issue for tracking
5. Re-run pip-audit with transitive ignores — PR passes only if direct vulns are resolved
6. Scheduled runs also validate that previously ignored vulns are still unfixable

Removes continue-on-error: true so the action actually blocks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant