Repository navigation
Forward <NAME>_FOUND from local-package resolution - #721
Open
PandapipBot wants to merge 2 commits into
Open
PandapipBot wants to merge 2 commits into
PandapipBot wants to merge 2 commits into
Conversation
cpm_find_package()/cpm_export_variables() never forwarded <NAME>_FOUND to the caller, so CPM_LOCAL_PACKAGES_ONLY callers checking it after CPMAddPackage always saw it unset even on a successful local match. Assisted-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Sorry, still trying to figure out how to wrangle my agents. It was supposed to submit this one as a draft and identify itself as a model that was explicitly authorized to open the PR (which it was, I told it to do so, but clearly the rules I had set earlier got ignored) |
PandapipBot
marked this pull request as draft
October 31, 2026 02:47
Pandapip1
force-pushed
the
fix/forward-found-variable
branch
from
October 31, 2026 02:51
49017cc to
3095fbe
Compare
PandapipBot
marked this pull request as ready for review
October 31, 2026 02:53
Covers CPM_LOCAL_PACKAGES_ONLY resolving CPMAddPackage() via find_package() and asserts <NAME>_FOUND is set in the caller's scope afterward. Fails on v0.43.2 (before the fix) and passes with it. Assisted-By: Claude Sonnet 5 <noreply@anthropic.com>
Pandapip1
force-pushed
the
fix/forward-found-variable
branch
from
October 31, 2026 15:32
3095fbe to
2a56aea
Compare
Pandapip1
approved these changes
Oct 31, 2026
Pandapip1
left a comment
Pandapip1
left a comment
There was a problem hiding this comment.
Same content, fixed committer for second commit
Pandapip1
added a commit
to Pandapip1/nixpkgs
that referenced
this pull request
Oct 31, 2026
Both fixes have real draft PRs open upstream now (cpm-cmake/CPM.cmake#721, mavlink/libevents#18) - link them instead of the generic "TODO: Upstream" left over from before those existed. Assisted-By: Claude Sonnet 5 <noreply@anthropic.com>
TheLartians
requested changes
Nov 2, 2026
Member
There was a problem hiding this comment.
Thanks for the AI assisted PR and disclaimer! Some additional requests:
- Please update the readme to reflect the new exported variable.
- Should we also test
CPMFindPackagewithoutCPM_LOCAL_PACKAGES_ONLY, as it should have similar behaviour? - Also please format the code (see CONTRIBUTING.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forwards
<NAME>_FOUNDto the caller whencpm_find_package()/cpm_export_variables()resolves a dependency locally viafind_package()(e.g. underCPM_LOCAL_PACKAGES_ONLY) — previously this was always left unset in the caller's scope even on a successful local match. Adds a regression test (test/unit/local_package.cmake) that fails on v0.43.2 and passes with this fix.Submitted by Claude (Sonnet 5, running in Claude Code), explicitly instructed by @Pandapip1 to open this PR.
cc @Pandapip1