Stabilize RTP electric-field ramp energy - #5803
Merged
DCM-Uni-Paderborn merged 2 commits intoAug 21, 2026
Merged
Conversation
Contributor
Author
|
/cp2kci sdbg intel-ifx-ssmp intel-ifx-psmp intel-ifort-ssmp intel-ifort-psmp openmpi-psmp psmp-4ranks rawhide-pdbg |
DCM-Uni-Paderborn
marked this pull request as ready for review
August 20, 2026 22:14
Contributor
Author
|
/cp2kci intel-ifx-ssmp intel-ifx-psmp intel-ifort-ssmp intel-ifort-psmp openmpi-psmp psmp-4ranks rawhide-pdbg |
DCM-Uni-Paderborn
force-pushed
the
stabilize-rtp-ramp-energy
branch
from
August 21, 2026 09:05
f77af1d to
3b409c6
Compare
Contributor
Author
|
/cp2kci sdbg ssmp |
This was referenced Aug 21, 2026
DCM-Uni-Paderborn
force-pushed
the
stabilize-rtp-ramp-energy
branch
from
August 21, 2026 15:56
3b409c6 to
4afcc1b
Compare
Contributor
Author
|
/cp2kci sdbg ssmp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two Ehrenfest/RTP energy matchers sat just below their observed cross-build numerical variation after #5755 corrected diagonal second derivatives of overlap integrals.
H2-emd-efield-ramp.inpreference to the corrected serial-debug value,-0.870455433182, and use a3e-11relative tolerance.H2O-ls-emd-mixing.inpfrom2e-11to3e-11; its reference remains unchanged. The optimized GNUssmpCI result differed by2.10e-11, just beyond the former limit.These are matcher-only changes. No source code or regtest input is changed.
Validation
-0.870455433182for the field-ramp test with a currentpsmpbuild.ssmpon Spark and ranH2O-ls-emd-mixing.inpfive times each with 1, 2, and 4 OpenMP threads. All 15 runs remained within1.3e-11of the retained reference; the last digits vary slightly with threaded reductions../make_pretty.shgit diff --checkCurrent CI status
The two RTP tests changed here pass in the targeted
sdbgandssmpruns. The remaining failures are outside this patch:master, addressed by Stabilize GFN2 modified Broyden regtest #5810TDDFPT_Check_Osc_Strengthresult inssmp(1.01e-5versus a1.0e-5tolerance), which passed unchanged in a subsequentssmprunNo reported failure is attributable to the RTP matcher changes.