Skip to content

Stabilize RTP electric-field ramp energy - #5803

Merged
DCM-Uni-Paderborn merged 2 commits into
cp2k:masterfrom
DCM-Uni-Paderborn:stabilize-rtp-ramp-energy
Aug 21, 2026
Merged

Stabilize RTP electric-field ramp energy#5803
DCM-Uni-Paderborn merged 2 commits into
cp2k:masterfrom
DCM-Uni-Paderborn:stabilize-rtp-ramp-energy

Conversation

@DCM-Uni-Paderborn

@DCM-Uni-Paderborn DCM-Uni-Paderborn commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Two Ehrenfest/RTP energy matchers sat just below their observed cross-build numerical variation after #5755 corrected diagonal second derivatives of overlap integrals.

  • Update the H2-emd-efield-ramp.inp reference to the corrected serial-debug value, -0.870455433182, and use a 3e-11 relative tolerance.
  • Raise only the tolerance of H2O-ls-emd-mixing.inp from 2e-11 to 3e-11; its reference remains unchanged. The optimized GNU ssmp CI result differed by 2.10e-11, just beyond the former limit.

These are matcher-only changes. No source code or regtest input is changed.

Validation

  • Reproduced -0.870455433182 for the field-ramp test with a current psmp build.
  • Built current master as GNU ssmp on Spark and ran H2O-ls-emd-mixing.inp five times each with 1, 2, and 4 OpenMP threads. All 15 runs remained within 1.3e-11 of the retained reference; the last digits vary slightly with threaded reductions.
  • ./make_pretty.sh
  • git diff --check

Current CI status

The two RTP tests changed here pass in the targeted sdbg and ssmp runs. The remaining failures are outside this patch:

  • the platform-sensitive GFN2 modified-Broyden test added on master, addressed by Stabilize GFN2 modified Broyden regtest #5810
  • one borderline TDDFPT_Check_Osc_Strength result in ssmp (1.01e-5 versus a 1.0e-5 tolerance), which passed unchanged in a subsequent ssmp run

No reported failure is attributable to the RTP matcher changes.

@DCM-Uni-Paderborn

Copy link
Copy Markdown
Contributor Author

/cp2kci sdbg intel-ifx-ssmp intel-ifx-psmp intel-ifort-ssmp intel-ifort-psmp openmpi-psmp psmp-4ranks rawhide-pdbg

@DCM-Uni-Paderborn
DCM-Uni-Paderborn marked this pull request as ready for review August 20, 2026 22:14
@DCM-Uni-Paderborn

Copy link
Copy Markdown
Contributor Author

/cp2kci intel-ifx-ssmp intel-ifx-psmp intel-ifort-ssmp intel-ifort-psmp openmpi-psmp psmp-4ranks rawhide-pdbg

@DCM-Uni-Paderborn
DCM-Uni-Paderborn force-pushed the stabilize-rtp-ramp-energy branch from f77af1d to 3b409c6 Compare August 21, 2026 09:05
@DCM-Uni-Paderborn

Copy link
Copy Markdown
Contributor Author

/cp2kci sdbg ssmp

@DCM-Uni-Paderborn
DCM-Uni-Paderborn force-pushed the stabilize-rtp-ramp-energy branch from 3b409c6 to 4afcc1b Compare August 21, 2026 15:56
@DCM-Uni-Paderborn

Copy link
Copy Markdown
Contributor Author

/cp2kci sdbg ssmp

@DCM-Uni-Paderborn
DCM-Uni-Paderborn merged commit d788ef1 into cp2k:master Aug 21, 2026
68 checks passed
@DCM-Uni-Paderborn
DCM-Uni-Paderborn deleted the stabilize-rtp-ramp-energy branch August 21, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant