Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Sync Gateway’s fleet manager metrics reporter to align its reporting behavior with Couchbase Server’s fleet manager collector settings, so metrics are only sent when the collector is enabled and at the server-configured interval.
Changes:
- Add management-API settings fetch (
/internal/settings/telemetry) and use it to gate reporting + drive the ticker interval (with safe defaults on transient failures). - Centralize telemetry endpoint/URI construction in
baseand add safe conversion from “hours” totime.Durationwith overflow protection. - Move/expand fleet manager reporter tests into a dedicated test file and add unit tests for interval conversion.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rest/server_context_test.go | Removes fleet manager reporter-related tests from this larger test file. |
| rest/fleet_manager_reporter.go | Implements collector settings fetch + enabled/interval-driven reporting loop; factors mgmt endpoint validation. |
| rest/fleet_manager_reporter_test.go | Adds dedicated reporter tests for settings, ingest behavior, and RBAC scenario. |
| base/fleet_manager_collector.go | Adds telemetry settings endpoint const, ingest URI builder, and settings interval conversion helper. |
| base/fleet_manager_collector_test.go | Adds unit coverage for FleetManagerCollectorSettings.Interval() fallback/overflow behavior. |
Comment on lines
+34
to
+37
| report := func(settings base.FleetManagerCollectorSettings) { | ||
| if !settings.Enabled { | ||
| return | ||
| } |
Contributor
Author
There was a problem hiding this comment.
filed https://jira.issues.couchbase.com/browse/CBG-5596 for this
bbrks
requested changes
Jul 15, 2026
bbrks
left a comment
bbrks
left a comment
Member
There was a problem hiding this comment.
one suggestion to avoid potential -race issues w/ test otherwise looks good
bbrks
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-5525
sendFleetManagerMetricsis tolerant to 404 errors in any casePre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiDependencies (if applicable)
Integration Tests