Skip to content

CBG-4600 apply networkType to cbgt#8439

Open
torcolvin wants to merge 2 commits into
mainfrom
CBG-4600
Open

CBG-4600 apply networkType to cbgt#8439
torcolvin wants to merge 2 commits into
mainfrom
CBG-4600

Conversation

@torcolvin

@torcolvin torcolvin commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

CBG-4600 apply networkType to cbgt

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

Copilot AI review requested due to automatic review settings July 9, 2026 17:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Sync Gateway’s DCP sharded import (cbgt manager setup) to propagate the network connection-string option into cbgt/gocbcore configuration, and refactors connection-string parsing to use gocbcore/v10/connstr instead of the older gocbconnstr package.

Changes:

  • Switch connection-string parsing to github.com/couchbase/gocbcore/v10/connstr and add a shared helper for typed option retrieval.
  • Refactor cbgt manager option construction into cbgtManagerOptions, and apply network as gocbcoreIOConfigNetworkType when present.
  • Add/extend unit tests covering typed option parsing and cbgt manager option building for network and kv_buffer_size scenarios.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
go.mod Removes direct dependency on github.com/couchbaselabs/gocbconnstr v1.
go.sum Drops gocbconnstr v1 checksums consistent with go.mod cleanup.
base/gocb_connection_string.go Switches to gocbcore/connstr and introduces getConnSpecOption + networkKey.
base/gocb_connection_string_test.go Adds unit tests for getConnSpecOption for int and string options.
base/dcp_sharded.go Introduces cbgtManagerOptions helper and applies network to cbgt options.
base/dcp_test.go Adds tests validating cbgt manager options include gocbcoreIOConfigNetworkType when network is set.

Comment thread base/gocb_connection_string.go
Comment thread base/gocb_connection_string.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants