Skip to content

CBG-5470: Add adversarial testing for metadata migration#8371

Open
torcolvin wants to merge 3 commits into
mainfrom
CBG-5470
Open

CBG-5470: Add adversarial testing for metadata migration#8371
torcolvin wants to merge 3 commits into
mainfrom
CBG-5470

Conversation

@torcolvin

@torcolvin torcolvin commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

CBG-5470

  • Add adversarial tests for metadata migration
  • Add non-_default tests for metadata migration
  • Detect and handle dropped collections underneath running metadata migration

Dependencies (if applicable)

Integration Tests

This comment was marked as outdated.

@bbrks bbrks changed the title CBG-5461: Support dropping _default._default after metadata migration… add manualbucketpooltest for supporting non-standard bucket testing (e.g. no _default collection) Jun 16, 2026
@bbrks bbrks self-assigned this Jun 16, 2026
@bbrks bbrks changed the title add manualbucketpooltest for supporting non-standard bucket testing (e.g. no _default collection) CBG-5470 add manualbucketpooltest for supporting non-standard bucket testing (e.g. no _default collection) Jun 16, 2026

@gregns1 gregns1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestMigrationThenDropDefaultCollectionTwoDatabases seems to fail for me for 8.0.0 version on server. When I run against 7.6.5 it passes. I can see in version 8.0.0 the indexes are stuck in building state in the UI.

I think it may be a case of collecting logs from CBS between versions and raising ticket with indexing team.

In addition, I've had TestDropDefaultCollectionDuringMigration pass and fail (it seems a bit flaky with timing issues). Given this isn’t a supported case and I think it can be hard for us to gracefully handle this situation I think it may be a candidate to drop out of this PR.

I also wonder if we should pull my test in defaultcollectiondroptest into here?

@torcolvin

Copy link
Copy Markdown
Collaborator Author

I know that some of the tests weren't testing things that we intended to support, but I was curious to see the behavior. I was running the tests with 8.0.1

torcolvin and others added 3 commits July 15, 2026 13:20
- allow creating test buckets that can be dropped independently of the bucket pool.
- Example of tests which do not have _default collection
Removes the standalone defaultcollectiondroptest package and merges its
richer migration-then-drop scenario into TestMigrationThenDropDefaultCollection
in manualbucketpooltest: assert metadata moved off _default._default, use a
named-collection doc round-trip, and probe that a new opt-out database can no
longer be created once _default._default is gone.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@bbrks bbrks changed the title CBG-5470 add manualbucketpooltest for supporting non-standard bucket testing (e.g. no _default collection) CBG-5470: Add adversarial testing for metadata migration Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants