fix(passkeys): declare the meta dependency required by Pigeon generated code - #313
Merged
Merged
Conversation
…ed code Pigeon 26.3.4 imports package:meta in the generated messages.g.dart files, so pub.dev rejected the passkeys_android, passkeys_darwin, passkeys_windows and passkeys_doctor publishes with: This package does not have meta in the dependencies section of pubspec.yaml
passkeys_darwin 0.4.4+4 and passkeys_windows 0.1.4+3 were never published, so they become 0.4.4 and 0.1.4 and the passkeys constraints follow. The workspace now requires the latest Melos, which is what melos-action already activates in the release workflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Publish Packagesruns forpasskeys_android2.14.0,passkeys_darwin0.4.4+4,passkeys_doctor1.6.1 andpasskeys_windows0.1.4+3 (triggered by #312) all failed with the same pub.dev validation error:Since the Pigeon 26.3.4 regeneration in #306, every generated
messages.g.dartimportspackage:meta/meta.dart, but none of the four packages declaredmetaas a dependency. The workspace resolved it transitively through Flutter, so analysis and tests passed, and onlypub publishvalidation caught it.Changes
meta: ^1.16.0to thedependenciesof the four packages that contain Pigeon generated code.dart pub publish --dry-runnow passes validation for all four.passkeys_darwin0.4.4+4 andpasskeys_windows0.1.4+3 were never published, so they become 0.4.4 and 0.1.4, the matching changelog headings are renamed, and thepasskeysconstraints follow. Melos only keeps incrementing the build number when one is present, so future bumps stay plain semver.^8.7.0(the latest release) in the workspace.melos-actionalready activates the latest Melos in the release workflows, so this aligns local runs with CI.Follow-up
The tags for the four failed versions point at a commit without this fix, so they cannot be republished as-is. After merging, run
Prepare Releaseagain. A local simulation ofmelos versionon this branch bumpspasskeys_androidto 2.14.1,passkeys_darwinto 0.4.5,passkeys_doctorto 1.6.2,passkeys_windowsto 0.1.5, andpasskeysto 2.23.1 with matching constraints, followed bycorbado_authandcorbado_auth_firebase. Until that release is out, the already publishedpasskeys2.23.0 andcorbado_auth3.8.4 are unresolvable on pub.dev because they depend on platform package versions that were never published.