Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
cache: 'npm'

- name: Install latest npm
run: npm install -g npm@latest
run: npm install -g npm@latest --min-release-age=2

- name: Install dependencies
run: npm ci
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
cache: 'npm'

- name: Install latest npm
run: npm install -g npm@latest
run: npm install -g npm@latest --min-release-age=2

- name: Install dependencies
run: npm ci
Expand All @@ -43,7 +43,7 @@ jobs:
cache: 'npm'

- name: Install latest npm
run: npm install -g npm@latest
run: npm install -g npm@latest --min-release-age=2

- name: Install dependencies
run: npm ci
Expand All @@ -65,7 +65,7 @@ jobs:
cache: 'npm'

- name: Install latest npm
run: npm install -g npm@latest
run: npm install -g npm@latest --min-release-age=2

- name: Install dependencies
run: npm ci
Expand Down Expand Up @@ -108,7 +108,7 @@ jobs:
cache: 'npm'

- name: Install latest npm
run: npm install -g npm@latest
run: npm install -g npm@latest --min-release-age=2

- name: Install dependencies
run: npm ci
Expand Down Expand Up @@ -138,7 +138,7 @@ jobs:
cache: 'npm'

- name: Install latest npm
run: npm install -g npm@latest
run: npm install -g npm@latest --min-release-age=2

- name: Install dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
cache: 'npm'

- name: Install latest npm
run: npm install -g npm@latest
run: npm install -g npm@latest --min-release-age=2

- name: Install dependencies
run: npm ci
Expand Down
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
@contentful:registry=https://registry.npmjs.org
ignore-scripts=true
min-release-age=2
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18
v26.13.0
Comment thread
linuxoptics marked this conversation as resolved.
Resolved
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@

| Tool | Version | Notes |
|---|---|---|
| Node.js | 18+ | CI runs on Node 24; local dev works on 18+ |
| Node.js | 18+ | CI runs on Node 26 and `.nvmrc` pins 26.13.0; local dev works on 18+ |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs omit npm requirement

This row now documents Node 26 for CI, but the PR's new .npmrc min-release-age=2 is silently ignored by npm < 11.10.0 — which is what Node 18 (still advertised here as "local dev works on 18+") bundles. A contributor on 18 gets no release-age protection. Please note the npm >= 11.10.0 requirement and align the npm row with the workflows' --min-release-age=2.

Suggested based on your custom review guideline "Repo Truth And Alignment"
Code Review Run #ef22e0

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

  • Yes, avoid them

| npm | latest | `npm install -g npm@latest` |

## Getting Started
Expand Down
Loading