feat(pnpm-policy): default the wait to two days - #113
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two weeks was the wrong tradeoff to ship as a default. A compromised release — hijacked account, typosquat, malicious postinstall — is normally reported and yanked within hours, so almost everything a cooldown buys you lands in the first day or two; the remaining twelve days mostly buy the sensation of security while making every legitimate upgrade feel like it needs a waiver. A default people route around is worth less than a shorter one they leave on.
Also flows through
pnpm-policy init's starter config, the README's config table and examples, and@constructive-io/pnpm-policy's ownpnpm-policy.yaml(the data package our repos pin). Consuming repos set the value explicitly, so this only reaches them if they follow —constructiveandconstructive-dbdo, in their own PRs.Link to Devin session: https://app.devin.ai/sessions/ffa3b012deac4eb7afb8f49a9af9f9ca
Requested by: @pyramation