Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore explicit newlines between logical lines in
DrawState::draw_to_termwhenmove_cursoris disabled.Problem
In #790,
DrawState::draw_to_termstopped callingterm.write_line("")between logical lines and padded every line with spaces toterm_width, relying on right-margin auto-wrap to advance rows. In the default mode (!self.move_cursor), all previous lines are already erased viaterm.clear_line()up front, so padding intermediate lines to force a wrap is unnecessary and loses row/cursor sync if terminal wrapping or width differs fromterm_width(for example on resize, wider PTYs, or disabled auto-wrap).Changes
term.write_line("")between logical lines when!self.move_cursor, and only write trailingwrite_line_fillerspaces after the last printed line (src/draw_target.rs).self.move_cursoris enabled so shorter updated lines still clear trailing characters from prior ticks (Clear the rest of line after drawing to the terminal #790).multi_progress_many_barsandmulti_progress_many_spinnersintests/render.rsfor the restoredNewLinetransitions, and add regression tests for multiline explicit newlines, wider-terminal redraws, andset_move_cursor(true)shortened-line clearing (src/draw_target.rs,tests/render.rs).Fixes #859