Only warn when attempting to install an AMD64 EXE installer on ARM64 - #1337
Merged
Conversation
lrandersson
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The architecture checks introduced in #1323 for EXE installers prevent the installation of an AMD64 EXE installer onto an ARM64 system. ARM64, however, can run AMD64 executables with emulation. Instead of aborting, issue a warning to the user. Non-interactive installations will continue whereas the user is presented with a choice about whether they wish to continue (see screenshots).
I also used the opportunity to add output for non-interactive installations for the other checks and remove hard-coded line breaks (NSIS does it automatically).
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?