Repository navigation
Conversation
Pre-release test of the go-yaml v4 release candidate ahead of v4.0.0, as requested in docker/compose#14432. rc.9 restores the default alias and depth limits in Node.Decode (yaml/go-yaml#475), so no change is needed in the loader. Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does, in one sentence
Bumps
go.yaml.in/yaml/v4fromv4.0.0-rc.4to thev4.0.0-rc.9release candidate so that CI runs compose-go's suites against it before go-yaml v4.0.0 ships.Context
compose-go pins
v4.0.0-rc.4, while Compose already requires a more recent candidate and go-yaml v4.0.0 is due on November 4, 2026 (see docker/compose#14432). The previous test PR, onv4.0.0-rc.8(#981), needed a workaround inResetProcessor: sincev4.0.0-rc.5,Node.Decodeno longer applied go-yaml's default alias and depth limits, so the alias-bomb test never returned. That regression was reported upstream and fixed in rc.9 (yaml/go-yaml#475).What the PR brings
Only the
go.mod/go.sumbump, with no change in the loader. The whole test suite passes with rc.9, includingTestAliasBombPrevented, which confirms that the upstream fix makes the workaround of #981 unnecessary.This is a test PR, opened as a draft and not meant to be merged before the final v4.0.0 is published. The matching Compose PR is docker/compose#14446.
🤖 Generated with Claude Code