Clean up options for ramntupleview into a struct - #69
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,8 +1,11 @@ | |||
| #ifndef RAMCORE_RAMNTUPLEVIEW_H | |||
| #define RAMCORE_RAMNTUPLEVIEW_H | |||
| #include <Rtypes.h> | |||
There was a problem hiding this comment.
warning: 'Rtypes.h' file not found [clang-diagnostic-error]
#include <Rtypes.h>
^| bool fPerfStats = false; | ||
| std::string perfStatsFilename = "perf.root"; | ||
| }; | ||
| Long64_t ramntupleview(const char *file, const char *query = "", const RAMNTupleViewOpts & = RAMNTupleViewOpts()); |
There was a problem hiding this comment.
warning: parameter 3 is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
Suggested change
| Long64_t ramntupleview(const char *file, const char *query = "", const RAMNTupleViewOpts & = RAMNTupleViewOpts()); | |
| Long64_t ramntupleview(const char *file, const char *query = "", RAMNTupleViewOpts & = RAMNTupleViewOpts()); |
| @@ -1,5 +1,6 @@ | |||
| #include <benchmark/benchmark.h> | |||
There was a problem hiding this comment.
warning: 'benchmark/benchmark.h' file not found [clang-diagnostic-error]
#include <benchmark/benchmark.h>
^| const char *perfstatsfilename = "perf.root"); | ||
| Long64_t ramntupleview(const char *file, const char *query, bool cache = true, bool perfstats = false, | ||
| const char *perfstatsfilename = "perf.root"); | ||
| Long64_t ramntupleview(const char *file, const char *query, RAMNTupleViewOpts &opts); |
There was a problem hiding this comment.
warning: function 'ramntupleview' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]
Suggested change
| Long64_t ramntupleview(const char *file, const char *query, RAMNTupleViewOpts &opts); | |
| Long64_t ramntupleviewstatic (const char *file, const char *query, RAMNTupleViewOpts &opts); |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #69 +/- ##
========================================
Coverage 71.78% 71.78%
========================================
Files 19 19
Lines 1985 1985
Branches 783 784 +1
========================================
Hits 1425 1425
Misses 443 443
Partials 117 117
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
AdityaPandeyCN
added a commit
to AdityaPandeyCN/ramtools
that referenced
this pull request
Sep 4, 2026
Bring in RAMNTupleViewOpts from compiler-research#69 and keep the silent-data-loss region-query behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.