Repository navigation
Add pms_smartlock_tesa (TESA Smartair) and pass PIN in lock sync - #98
Merged
Merged
Conversation
New vendor module pms_smartlock_tesa wiring TESA Smartair into the smartlock framework, mirroring the ttlock/omnitec pattern: vendor_type "tesa", on-prem connection params on lock.vendor (host, port, operator name/password, verify_ssl) since TESA has no cloud, and get_connector() returning the TesaSmartairProvider from the roomdoo_locks_tesa library. pms_smartlock_base now passes the grant's PIN to modify_access/ revoke_access (read under sudo, never exposed): TESA needs it to re-resolve live state and confirm a stay is ours before acting, and to recreate a grant when the start date changes. The PIN stays in the group-restricted field and is never written to vendor_grant_ref. Depends on the roomdoo_locks_tesa library and the additive pin contract (roomdoo-smartlocks#22); requirements declare the new lib.
Diff CoverageDiff: origin/16.0...HEAD, staged and unstaged changesNo lines with coverage information in this diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
New vendor module
pms_smartlock_tesawiring TESA Smartair into the smartlock framework, mirroring the TTLock/Omnitec pattern:vendor_typeselection addstesa("TESA Smartair").lock.vendor: host, port (8181), operator name/password,verify_ssl.get_connector()returns theTesaSmartairProviderfrom theroomdoo_locks_tesalibrary._pin_confirm_key_defaults()entry + vendor form view.Plus a change in
pms_smartlock_base:_sync_modify/_sync_removenow pass the grant's PIN tomodify_access/revoke_access. TESA needs it to re-resolve live state (a pre-assignment auto-activates into a check-in, the stored handle goes stale) and to recreate a grant when the start date changes. The PIN is read undersudo, stays in the group-restricted field, and is never written tovendor_grant_ref.Dependency
Depends on the library PR commitsun/roomdoo-smartlocks#22 (the new
roomdoo_locks_tesapackage + the additivepin=Noneonmodify_access/revoke_access). Merge that first — until it lands on the lib'smain, the additivepinkwarg won't exist.requirements.txt/requirements-overrides.txtdeclare the new lib at@main.Tests
Vendor module tests pass; the library behaviour (auto-activation re-resolution, start-change recreate) is covered in the lib PR and validated end-to-end against a real Smartair server.