Repository navigation
[FIX] pms_fastapi: keep the invoice note when creating from folios - #169
Merged
Merged
Conversation
POST /folios/invoices overwrote the narration that _create_invoices copies from the folio note or the company invoice terms with the payload value, whose schema default is an empty string. Creating an invoice from the front without typing a note therefore erased that text (for some properties, a legal or GDPR clause). An empty narration now means "not provided" and keeps the default note; a non-empty one still replaces it.
Diff CoverageDiff: origin/16.0...HEAD, staged and unstaged changes
Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /folios/invoices overwrote the narration that _create_invoices copies from the folio note or the company invoice terms with the payload value, whose schema default is an empty string. Creating an invoice from the front without typing a note therefore erased that text (for some properties, a legal or GDPR clause).
An empty narration now means "not provided" and keeps the default note; a non-empty one still replaces it.