Repository navigation
[16.0][FIX] pms_api_rest: don't reject a guest for a state of another country - #168
Merged
Merged
Conversation
Zip autocompletion, OCR or a returning customer may leave a residence
state of another country, hidden in the app for countries without
states, so the guest could not be saved ("State and country of
residence do not match"). The guest endpoints now drop it; Spanish
residents keep the usual validation (INE, SES).
Diff CoverageDiff: origin/16.0...HEAD, staged and unstaged changes
Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: saving a guest from the app fails with "State and country of residence do not match" when zip autocompletion, OCR or a returning customer leaves a state of another country (e.g. a French zip that also exists in Spain gets a Spanish state). For countries without states the app hides that field, so the user cannot clear it and the guest cannot be checked in.
Fix: the guest endpoints (reception and online check-in) drop a residence state that does not belong to the residence country. Spanish residents are not affected: their state is required (INE, SES) and validated as before.
Tests:
test_checkin_partner_residence_state(4 tests).Related: OCA/pms#459 (the residence country of foreign guests is cleared on their first save). Both are needed to check in a foreign guest from the app.