fix(CDS-801): bump light fgPositive to green70 for AA contrast - #832
Open
adrienzheng-cb wants to merge 1 commit into
Open
fix(CDS-801): bump light fgPositive to green70 for AA contrast#832adrienzheng-cb wants to merge 1 commit into
adrienzheng-cb wants to merge 1 commit into
Conversation
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
github-actions
Bot
added
packages:common
packages:web
packages:mobile
packages:mcp-server
labels
Contributor
cb-ekuersch
previously approved these changes
Aug 7, 2026
Collaborator
|
Review Error for cb-ekuersch @ 2026-08-07 18:55:54 UTC |
Light fgPositive on grey card backgrounds (bgAlternate) was 4.1:1. Map light fgPositive to green70 (~5.4:1). Dark mode already passes. Co-authored-by: Cursor <cursoragent@cursor.com>
adrienzheng-cb
force-pushed
the
adrien/cds-801-fg-positive-contrast
branch
from
August 7, 2026 19:12
f8c3206 to
6d43e2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Light-mode
fgPositive(green60/#098551) on grey card backgrounds (bgAlternate/#EEF0F3) had a 4.1:1 contrast ratio, below WCAG AA 4.5:1 for normal text. Fixes CDS-801 / A11Y-805.Per design guidance (Anna): map light
fgPositive→green70(~5.4:1 onbgAlternate).Root cause (required for bugfixes)
Default/coinbase themes used
lightSpectrum.green60forfgPositive. That green fails AA ongray10card surfaces.Dark
fgPositivealready clears AA (~6.4:1 on darkbgAlternate), so it is unchanged. High-contrast themes already usegreen80.UI changes
Light-mode positive text (
fgPositive) is slightly darker green. No intentional dark-mode or high-contrast visual change.Testing
How has it been tested?
Testing instructions
color="fgPositive") onbackground="bgAlternate"/ grey card.#047043on#EEF0F3).Change management
type=routine
risk=low
impact=sev5
automerge=false
Made with Cursor