Repository navigation
fix: size menu bar item to fit content, avoiding truncation - #34
Merged
Merged
Conversation
The status item used a fixed 76pt width, which could truncate the weekly prefix/percent text when content was wider and leave excess padding when narrower. Replace it with dynamic sizing driven by the view's actual content. MenuBarQuotaView now exposes preferredWidth (computed from the icon, weekly prefix label, percent label, and their spacing) and an intrinsicContentSize override. AppDelegate configures the status item with NSStatusItem.variableLength and syncs statusItem.length to preferredWidth on every snapshot update, so the item always matches its content - no truncation, no extra padding. Also extract layout magic numbers into a Metrics enum and refresh intrinsic size after each update.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe status-bar item now uses variable length derived from ChangesDynamic status item sizing
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status item used a fixed 76pt width, which could truncate the weekly prefix/percent text when content was wider and leave excess padding when narrower.
Replace it with dynamic sizing driven by the view's actual content.
MenuBarQuotaView now exposes preferredWidth (computed from the icon, weekly prefix label, percent label, and their spacing) and an intrinsicContentSize override. AppDelegate configures the status item with NSStatusItem.variableLength and syncs statusItem.length to preferredWidth on every snapshot update, so the item always matches its content - no truncation, no extra padding.
Also extract layout magic numbers into a Metrics enum and refresh intrinsic size after each update.
Summary by CodeRabbit
New Features
Bug Fixes