fix(security): tighten command injection regex + add ignore rules logging#327
Closed
ajianaz wants to merge 1 commit into
Closed
fix(security): tighten command injection regex + add ignore rules logging#327ajianaz wants to merge 1 commit into
ajianaz wants to merge 1 commit into
Conversation
…ging - Tighten injection/exec regex: only flag subprocess.run when dynamic input signals present (f-string, format(), shell=True, string concat with user input). Literal list calls like subprocess.run(cmd) are safe. - Add debug logging to apply_ignore_rules for better diagnostics - Add unit tests for ignore_rules (title match, issue_type match, empty, case insensitive) - Add unit tests for security_scanner (no FP on literal list, triggers on f-string and shell=True) Fixes #326
ajianaz
force-pushed
the
fix/reduce-security-scanner-fp
branch
from
d4a460b to
7759790
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The injection/exec security scanner regex matches every subprocess.run() call,
including safe ones with controlled literal lists. This causes false positives
in legitimate subprocess calls.
Also, apply_ignore_rules() had no debug logging.
Changes
(f-string, format(), shell=True, string concat with user input)
Closes #326