Repository navigation
Parse event stream fields without a colon - #53
Merged
Merged
Conversation
Contributor
Author
|
I fixed the PHP 5.6 failure in 80ba24b. Empty field values now stay strings, so event: keeps the default message type. |
clue
approved these changes
Oct 7, 2026
clue
left a comment
Owner
There was a problem hiding this comment.
@bensynapse Thanks for looking into this and fixing the legacy builds, changes LGTM! Matches the spec and a local spike I had for this back in 2022, so great to see this land with proper tests
Keep it coming 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
A bare
idline currently leaves the previous event ID set. The next reconnect then sends that staleLast-Event-IDheader.The SSE parsing rules define an empty value for fields without a colon.
The fix clears bare
idfields and preserves empty lines from baredatafields. A bareretryremains ignored.The tests check parser output, decoder state and the reconnect request headers. Five regression cases fail against the original parser.
PHP 8.4:
vendor/bin/phpunit --coverage-text --coverage-clover=clover.xmlpasses all 121 tests and 298 assertions. The workflow's coverage check passes with 100% statement coverage.PHP 7.2:
vendor/bin/phpunit -c phpunit.xml.legacyalso passes all 121 tests and 298 assertions.