Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
More detailed description
NewMessageJSONParsernow applies the default input source to a local copy ofMessageJSONParseConfig. Multiple parser constructors can reuse the same read-only config without racing, and omitting the input source still parses from message content.The regression parses the configured
idkey with the default source and verifies that the caller's config remains unchanged. The standalone example in the linked issue reported a read/write race andparse_from = "content"on the base commit. It printsparse_from = ""with no race report after this patch.go test -race ./schema ./composepassed on Go 1.26.9.gofmtand the repository's golangci-lint 2.8.0 (Go 1.25.5) passed.AI assistance was used to investigate, implement, and test the change.
Which issue(s) this PR fixes
Fixes #1484.