Skip to content

fix(chart): preserve BubbleMap view on data refresh#607

Open
AnmolSaini16 wants to merge 1 commit into
cloudflare:mainfrom
AnmolSaini16:fix/bubble-map-view-updates
Open

fix(chart): preserve BubbleMap view on data refresh#607
AnmolSaini16 wants to merge 1 commit into
cloudflare:mainfrom
AnmolSaini16:fix/bubble-map-view-updates

Conversation

@AnmolSaini16

@AnmolSaini16 AnmolSaini16 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Updates BubbleMap so bubble data refreshes do not reset the current map view. The chart now only resends the geo option when map data or view-related props change, while regular data updates can update the bubble series without resetting pan or zoom state.

Reviews

  • bonk has reviewed the change
  • automated review not possible because: this is a small chart interaction behavior change that needs reviewer validation in context

Tests

  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because:

@rozenmd

rozenmd commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

/bonk give us a review mate

@pkg-pr-new

pkg-pr-new Bot commented Jun 26, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/kumo@607

commit: 4db6584

@github-actions

Copy link
Copy Markdown
Contributor

Docs Preview

View docs preview

Commit: 4db6584

@ask-bonk

ask-bonk Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@rozenmd Bonk workflow was cancelled.

View workflow run · To retry, trigger Bonk again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants