You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
packages/kumo/src/components/tooltip/tooltip.tsx ✅ Just a minor whitespace fix (no functional change).
Decision
The migration is clean, well-tested, and preserves the existing API. The cnfast package appears purpose-built for this use case. Tests are comprehensive for Kumo-specific token patterns. Not approving — Approved ✅.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cnimplementation withcnfastwhile preserving the existing exportedcnAPI.clsxandtailwind-mergefrom@cloudflare/kumodependencies.Tests
pnpm install --frozen-lockfilepnpm --filter @cloudflare/kumo typecheckpnpm --filter @cloudflare/kumo exec vitest run --project=unit src/utils/cn.test.tspnpm --filter @cloudflare/kumo buildpnpm --filter @cloudflare/kumo testpnpm --filter @cloudflare/kumo validate:buildpnpm --filter @cloudflare/kumo lintReviews
bonk has reviewed the change
automated review not possible because: dependency migration was authored locally and has not been reviewed by bonk yet
Tests
Tests included/updated
Automated tests not possible - manual testing has been completed as follows:
Additional testing not necessary because: