Repository navigation
fix: preserve scalar and array body properties wrapped in allOf - #18
Merged
Merged
Conversation
jamesopstad
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single-member
allOfwrappers around scalar and array body properties were treated as object compositions and omitted fromOperationInfo.bodyParams. This drops flags such as--config-sourceand--connector-idwhen an upstream schema attachesx-fern-property-nameto a referenced field, as seen in cloudflare/cf#220.Resolve these wrappers during top-level and nested body-property extraction, preserving inherited schema metadata and property-local annotations. Regression tests cover renamed fields, enums, defaults, requiredness, sensitivity, read-only properties, nested wrappers, and scalar and object arrays.
Validation:
pnpm checkpnpm --filter @cloudflare/forge test— 37 tests passedpnpm --filter @cloudflare/forge typecheckpnpm check, 1,483 CLI tests, and 637 Wrangler compatibility tests passed.