Skip to content

chore: update Forge for UUID scalars - #358

Merged
petebacondarwin merged 1 commit into
mainfrom
codex/update-forge-uuid
Oct 19, 2026
Merged

petebacondarwin merged 1 commit into
mainfrom
codex/update-forge-uuid

Conversation

@petebacondarwin

Copy link
Copy Markdown
Collaborator

Forge now exposes format: uuid as a dedicated scalar. Updating the dependency without adapting the generator would drop UUID body flags and classify UUID query parameters as unknown.

Pin Forge to the merged cloudflare/forge#48 build (ca70d7f5d88da223e243bca25810199876242ea6), map UUID scalars to strings in body and parameter handling, and update the test plugin to the 0.3.0 interface. Add regression coverage for required/nullable UUID fields, referenced UUID arrays, and UUID query unions.

Regeneration with the unchanged OpenAPI pin produces no tracked output changes, so this compatibility update needs no changeset.

Validation:

  • Confirmed all four new regression cases fail without the UUID mappings and pass with them.
  • pnpm generate — generated output unchanged.
  • pnpm check — passed.
  • pnpm --filter cf test — 1,680 passed, 6 skipped.

@ask-bonk

ask-bonk Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@pkg-pr-new

pkg-pr-new Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/cf@358

commit: 0a69412

@clanky-the-clanker

clanky-the-clanker Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

✅ Approved — No issues found. The UUID scalar mappings cover both scalar switches in the generator, the test plugin import now targets the 0.3.0 interface, and new regression tests cover the UUID body and query cases.

The decision is advisory: this comment never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

No issues found.

  • packages/cli/generator/plugin/body.ts and packages/cli/generator/plugin/operation.ts hold the only two type.scalar switches that turn a scalar into a kind or a type string. Both now handle uuid the same way as string.

  • packages/cli/src/__tests__/helpers/forge-cli.ts now imports forge:plugin/forge@0.3.0. That was the only forge:plugin reference in the CLI package, so no 0.2.0 reference is left.

  • The new tests in forge-model.test.ts cover:

    • required and nullable UUID body fields
    • referenced UUID arrays
    • the three UUID query-parameter shapes

    They check both the emitted code and the _meta output.

  • The pull request adds no changeset. The repository's rules allow that when generated output does not change, and the description says regeneration changed nothing. This review could not confirm that.

  • This review treated the new Forge pin as a changed version string only. It could not confirm that the pinned build exports the uuid scalar and the 0.3.0 plugin interface.


📝 Documentation: ✅ LGTM

No documentation changes are needed for this compatibility update.


Reviewed commit: 0a694122

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

cf --help startup

mean stddev min max
PR 279.9 ms 6.3 ms 271.3 ms 297.1 ms
base 275.5 ms 6.8 ms 267.0 ms 294.5 ms

Δ (PR vs base): ↑ +4.4 ms (+1.6%)

Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.

@petebacondarwin
petebacondarwin force-pushed the codex/update-forge-uuid branch from 74e1e04 to e40f9a7 Compare October 19, 2026 15:27
@ask-bonk

ask-bonk Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@petebacondarwin
petebacondarwin force-pushed the codex/update-forge-uuid branch from e40f9a7 to 0a69412 Compare October 19, 2026 15:43
@ask-bonk

ask-bonk Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@petebacondarwin
petebacondarwin added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit 44cc2ca Oct 19, 2026
11 checks passed
@petebacondarwin
petebacondarwin deleted the codex/update-forge-uuid branch October 19, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants