chore(ui): Layer architecture for configure steps per IdP and protocol#8651
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
80e9446 to
8b20562
Compare
e2635af to
fc19027
Compare
fc19027 to
1f2eec2
Compare
1f2eec2 to
c1282bf
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis PR refactors the ConfigureSSO SAML wizard architecture from a monolithic single-component model into a modular, provider-routed design. It updates localization strings and TypeScript types to define a step-based configuration hierarchy for both Okta and Custom SAML providers. New shared UI components (AttributeMappingTable and IdentityProviderMetadataForm) encapsulate reusable attribute mapping and metadata submission logic. Provider-specific step implementations (SamlOktaConfigureSteps, SamlCustomConfigureSteps) compose four-step wizards that reuse shared components while applying provider-specific attribute mappings and field labels. A provider-routing ConfigureStep component dispatches to the correct step implementation, and a shared InnerStepCounter component is extracted for reuse across domain verification and SAML configuration flows. Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches⚔️ Resolve merge conflicts
Comment |
c1282bf to
f1cafb9
Compare
f1cafb9 to
df44a2a
Compare
Description
Introduces new architecture for adding configuration steps per IdP and protocol, making it more flexible to add Microsoft Entra + Google Workspace for SAML, and later OpenID connect.
Now, each protocol has it's folder within the provider types, and each provider should have it's inner steps created within a module, which allows for flexibility when composing the UI.
How to add a new SAML provider
ProviderTypeunionConfigureStep/index.tsxChecklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change