Skip to content

Commit 1bd824f

Browse files
refactor(mosaic): let the sign-in enterprise connection picker read its own copy
1 parent 9da14f2 commit 1bd824f

3 files changed

Lines changed: 5 additions & 16 deletions

File tree

‎packages/mosaic/src/features/sign-in/sign-in.view.tsx‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,9 @@ function choiceCopy(
4545
step: Extract<SignInStep, { kind: 'choice' }>,
4646
m: Messages,
4747
): { title: string; description: string } {
48-
switch (step.purpose) {
49-
case 'methods':
50-
return { title: m.alternativeMethods.title, description: m.alternativeMethods.description };
51-
case 'reset-methods':
52-
return { title: m.resetMethods.title, description: m.resetMethods.description };
53-
case 'enterprise-connections':
54-
return { title: m.enterpriseConnections.title, description: m.enterpriseConnections.description };
55-
}
48+
return step.purpose === 'reset-methods'
49+
? { title: m.resetMethods.title, description: m.resetMethods.description }
50+
: { title: m.alternativeMethods.title, description: m.alternativeMethods.description };
5651
}
5752

5853
export function SignInView({

‎packages/mosaic/src/features/sign-in/steps/choice-step.tsx‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ export function ChoiceStep({
5757
return (
5858
<SignInEnterpriseConnections
5959
focusRef={focusRef}
60-
title={messages.title}
61-
description={messages.description}
6260
logo={logo}
6361
connections={step.options}
6462
globalErrorMessage={globalErrorMessage}

‎packages/mosaic/src/features/sign-in/steps/sign-in-enterprise-connections.tsx‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ import { styles } from '../sign-in.styles';
1212
import type { SignInProvider } from '../sign-in.types';
1313

1414
interface SignInEnterpriseConnectionsProps {
15-
title: string;
16-
description: string;
1715
logo?: { src: string; alt: string };
1816
connections: readonly SignInProvider[];
1917
globalErrorMessage?: string;
@@ -24,8 +22,6 @@ interface SignInEnterpriseConnectionsProps {
2422
}
2523

2624
export function SignInEnterpriseConnections({
27-
title,
28-
description,
2925
logo,
3026
connections,
3127
globalErrorMessage,
@@ -50,8 +46,8 @@ export function SignInEnterpriseConnections({
5046
/>
5147
</Card.Media>
5248
) : null}
53-
<Card.Title>{title}</Card.Title>
54-
<Card.Description>{description}</Card.Description>
49+
<Card.Title>{m.enterpriseConnections.title}</Card.Title>
50+
<Card.Description>{m.enterpriseConnections.description}</Card.Description>
5551
</Card.Header>
5652
<Card.Banner
5753
role='alert'

0 commit comments

Comments
 (0)