Skip to content

Commit 9da14f2

Browse files
refactor(mosaic): name the sign-in provider type for social and enterprise providers
1 parent ffa739c commit 9da14f2

5 files changed

Lines changed: 11 additions & 11 deletions

File tree

‎packages/mosaic/src/features/sign-in/index.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ export { SignInView } from './sign-in.view';
22
export type {
33
SignInActionBlockedDetails,
44
SignInFactor,
5-
SignInSocialProvider,
5+
SignInProvider,
66
SignInStep,
77
SignInSubmitEvent,
88
SignInValues,

‎packages/mosaic/src/features/sign-in/sign-in.types.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export type SignInStep =
3434
provider?: string;
3535
}
3636
| { kind: 'choice'; purpose: 'methods' | 'reset-methods'; options: readonly SignInFactor[] }
37-
| { kind: 'choice'; purpose: 'enterprise-connections'; options: readonly SignInSocialProvider[] }
37+
| { kind: 'choice'; purpose: 'enterprise-connections'; options: readonly SignInProvider[] }
3838
| { kind: 'notice'; purpose: 'help' }
3939
| { kind: 'notice'; purpose: 'forgot-password'; identifier: string }
4040
| { kind: 'notice'; purpose: 'no-methods' | 'password-compromised' | 'enterprise-sso' }
@@ -51,7 +51,7 @@ export interface SignInActionBlockedDetails {
5151
traceId?: string;
5252
}
5353

54-
export interface SignInSocialProvider {
54+
export interface SignInProvider {
5555
id: string;
5656
name: string;
5757
iconUrl: string;
@@ -79,7 +79,7 @@ export interface SignInViewProps {
7979
applicationName: string;
8080
applicationLogoUrl?: string;
8181
combined: boolean;
82-
socialProviders: readonly SignInSocialProvider[];
82+
socialProviders: readonly SignInProvider[];
8383
pendingProviderId?: string;
8484
onSelectProvider: (id: string) => void;
8585
form: UseFormResult<SignInValues>;

‎packages/mosaic/src/features/sign-in/steps/identifier-step.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@ import { Text } from '../../../components/text';
1313
import { fill, useMessages } from '../../../localization';
1414
import { Form } from '../../../primitives/form';
1515
import { styles } from '../sign-in.styles';
16-
import type { SignInSocialProvider, SignInSubmitEvent, SignInValues } from '../sign-in.types';
16+
import type { SignInProvider, SignInSubmitEvent, SignInValues } from '../sign-in.types';
1717

1818
interface IdentifierStepProps {
1919
applicationName: string;
2020
combined: boolean;
2121
logo?: { src: string; alt: string };
22-
socialProviders: readonly SignInSocialProvider[];
22+
socialProviders: readonly SignInProvider[];
2323
pendingProviderId?: string;
2424
onSelectProvider: (id: string) => void;
2525
form: UseFormResult<SignInValues>;

‎packages/mosaic/src/features/sign-in/steps/sign-in-enterprise-connections.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ import { ProviderButton, ProviderButtonGroup } from '../../../components/provide
99
import { Text } from '../../../components/text';
1010
import { useMessages } from '../../../localization';
1111
import { styles } from '../sign-in.styles';
12-
import type { SignInSocialProvider } from '../sign-in.types';
12+
import type { SignInProvider } from '../sign-in.types';
1313

1414
interface SignInEnterpriseConnectionsProps {
1515
title: string;
1616
description: string;
1717
logo?: { src: string; alt: string };
18-
connections: readonly SignInSocialProvider[];
18+
connections: readonly SignInProvider[];
1919
globalErrorMessage?: string;
2020
pendingConnectionId?: string;
2121
onSelectConnection: (id: string) => void;

‎packages/swingset/src/stories/sign-in.stories.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import type { FieldsConfig } from '@clerk/mosaic/components/form';
33
import { useForm } from '@clerk/mosaic/components/form';
44
import type {
55
SignInFactor,
6-
SignInSocialProvider,
6+
SignInProvider,
77
SignInStep,
88
SignInSubmitEvent,
99
SignInValues,
@@ -31,7 +31,7 @@ const PHONE = '+1******0123';
3131

3232
const settleAfter = (ms: number) => new Promise<void>(resolve => setTimeout(resolve, ms));
3333

34-
const socialProviders: SignInSocialProvider[] = [
34+
const socialProviders: SignInProvider[] = [
3535
{ id: 'oauth_google', name: 'Google', iconUrl: 'https://img.clerk.com/static/google.svg' },
3636
{ id: 'oauth_github', name: 'GitHub', iconUrl: 'https://img.clerk.com/static/github.svg' },
3737
];
@@ -469,7 +469,7 @@ function StepPanel({
469469
globalErrorMessage?: string;
470470
isPending?: boolean;
471471
pendingProviderId?: string;
472-
providers?: SignInSocialProvider[];
472+
providers?: SignInProvider[];
473473
identifier?: string;
474474
otherMethods?: boolean;
475475
}) {

0 commit comments

Comments
 (0)