Skip to content

fix(ci): correct issue where docker image on PR couldn't be scanned b… - #46

Merged
jacdavi merged 2 commits into
cisagov:mainfrom
jacdavi:fix/pr_docker_scan
Oct 2, 2026
Merged

jacdavi merged 2 commits into
cisagov:mainfrom
jacdavi:fix/pr_docker_scan

Conversation

@jacdavi

@jacdavi jacdavi commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

🗣 Description

This corrects an issue where the pipeline would fail on external PRs because the docker image was not published and therefore couldn't be scanned.
Now the image is stored locally on PRs so the scan could complete.

💭 Motivation and context

Fixes failing pipelines on PRs.

🧪 Testing

This PR is a test itself

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@jacdavi
jacdavi force-pushed the fix/pr_docker_scan branch from ef41592 to 7616c45 Compare October 2, 2026 22:15
@jacdavi
jacdavi merged commit daed337 into cisagov:main Oct 2, 2026
6 checks passed
@jacdavi
jacdavi deleted the fix/pr_docker_scan branch October 2, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant