Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Starting with Android 17 (API 37), ART writes five additional keys in the
*versionsection of every method trace, right afterpid=:is_streaming,is_precise_traceend_time,end_tscandcompilation-filterThey come from
TraceWriter::CreateSummaryinruntime/trace.cconandroid17-release. The same function onandroid16-releasestops atpid=. They're written unconditionally, soparse()currently fails on every method trace recorded on Android 17.Changes
parse_header_linenow recognizes the five keys and validates their values: booleans foris_streamingandis_precise_trace, numbers forend_timeandend_tsc, and any text up to the newline forcompilation-filter. The values aren't stored, soAndroidTraceLogand the public API stay the same.The rest of the format is unchanged in Android 17. Threads, methods, the
SLOWheader and the event records all parse as before once these lines are accepted.Context
This came up in getsentry/relay#6517 and has been tested with getsentry/sentry-react-native#6892
Thanks for maintaining this crate 🙇