CFE-4699: Fixed reports promise being kept when the report could not be written - #6269
Open
nickanderson wants to merge 1 commit into
Open
CFE-4699: Fixed reports promise being kept when the report could not be written#6269nickanderson wants to merge 1 commit into
nickanderson wants to merge 1 commit into
Conversation
A report which never made it to its file was still audited as kept and still defined the _kept class. The promise fails now instead. The test for this has been soft-failing since 2015. It makes the file immutable with chattr, which needs root, so it also moves to an unsafe directory where testall runs it as root. Ticket: CFE-4699 Changelog: Title Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
larsewi
approved these changes
Aug 6, 2026
Member
Author
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14411/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14411/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the test into an unsafe directory, where testall runs it as root so the chattr it needs can work.
Ticket: CFE-4699