fix(plugin): bump to 1.2.1 so the head-SHA-gate review-pr.md actually ships; guard the class in CI - #23
Merged
Conversation
… ships; guard the class in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22.
What & why
Two changes, one concern — the plugin version must move when plugin content moves:
plugin.json1.2.0 → 1.2.1.25fa544(fix(review-pr): make the head-SHA check a gate that fails, not a note that can be believed #20) changedclaude-plugin/commands/review-pr.md— the head-SHA gate — without bumping the version, so everyclaude plugin updatesince has compared 1.2.0 to 1.2.0 and kept the old file. The fix for the stale-review class failed to ship through the exact channel built to ship it. Patch bump because fix(review-pr): make the head-SHA check a gate that fails, not a note that can be believed #20 was afix:.plugin-version-guard.yml— a PR-time check (path-filtered toclaude-plugin/**) that fails when plugin content changes without the version line changing. A version-only bump passes; a templates-only PR never runs it.Verification (both directions, per the CI rule)
The guard's exact check, replayed locally against real history:
f7e43be, head25fa544→content [claude-plugin/commands/review-pr.md] changed, version stayed 1.2.0→ fails.1.2.0 -> 1.2.1→ passes.This PR itself exercises the guard live (it touches
claude-plugin/and bumps the version), so its own checks page is the green run; a deliberately-red run can be demonstrated on request by reverting the bump commit on a scratch branch.What this does NOT do
claude plugin updateonce — that's the ops box on plugin version not bumped with content changes, soclaude plugin updateno-ops and the head-SHA-gate review-pr.md never ships #22.verify-release-version.yml(tag-time, for published packages) is untouched; this guard is PR-time and plugin-specific.