Conversation
Owner
|
Thank you for this great contribution. Right now the SfM pipeline is going through a major refactoring and new features are being added, so I'm not sure if it's best to merge this now or after I finish with the refactoring. |
Author
|
Thanks, and no problem. I’m happy to rebase and adapt the PR once the new structure has settled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ground control point support to
CreateStructure, including robustalignment to surveyed coordinates and retained GCP constraints during bundle
adjustment.
Changes
surveyed coordinate frame
accuracy-weighted surveyed-coordinate priors
CreateStructureand the Python bindingsThe new options are:
--import-gcp-csv--align-gcp-threshold--gcp-position-weightThe CSV columns are:
gcp_label,image_file_name,x,y,x_map,y_map,elev,x_map_acc,y_map_acc,elev_accUpstream integration
Current
developcontains GPS alignment, known-pose reconstruction, and sharedfinal/resection BA infrastructure, but no SfM GCP model or GCP-constrained BA.
This implementation uses those current pipeline structures and gives successful
GCP alignment precedence over imported-pose and GPS alignment.
Real-world use
The workflow was developed and exercised on historical aerial photographs from
the HistoriX project, including the Casa Grande and Iceland datasets. The earlier
implementation was used end to end to reconstruct the scanned aerial images,
align the results with surveyed GCPs, and produce georeferenced sparse and dense
point clouds for comparison with the supplied reference DEMs. The implementation
in this PR ports that workflow to current
developand adds stricter handling ofRANSAC-rejected controls.