-
Notifications
You must be signed in to change notification settings - Fork 359
Upgrade Guava library to version 32.0.0-jre in cdap #16149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AbhishekKumar9984
wants to merge
2
commits into
cdapio:cs_guava_upgrade
Choose a base branch
from
cloudsufi:metrics-cloudsufi-guava-upgrade
base: cs_guava_upgrade
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+137
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
130 changes: 130 additions & 0 deletions
130
cdap-data-fabric/src/main/java/org/apache/tephra/metrics/TxMetricsCollector.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| /* | ||
| * Copyright © 2026 Cask Data, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
|
|
||
| package org.apache.tephra.metrics; | ||
|
|
||
| import com.google.common.util.concurrent.AbstractIdleService; | ||
| import com.google.common.util.concurrent.Futures; | ||
| import com.google.common.util.concurrent.ListenableFuture; | ||
| import com.google.common.util.concurrent.Service; | ||
| import java.util.concurrent.Executor; | ||
| import java.util.concurrent.TimeUnit; | ||
| import java.util.concurrent.TimeoutException; | ||
|
|
||
| /** | ||
| * Workaround class compiled against Guava 32.0.0-jre to satisfy Tephra TransactionManager. | ||
| */ | ||
| public class TxMetricsCollector implements MetricsCollector { | ||
|
|
||
| private final Service delegate = new AbstractIdleService() { | ||
| @Override | ||
| protected void startUp() {} | ||
| @Override | ||
| protected void shutDown() {} | ||
| }; | ||
|
|
||
| public void configure(org.apache.hadoop.conf.Configuration conf) { | ||
| // no-op | ||
| } | ||
|
|
||
| @Override | ||
| public void gauge(String metricName, int value, String... tags) { | ||
| // no-op | ||
| } | ||
|
|
||
| @Override | ||
| public void histogram(String metricName, int value) { | ||
| // no-op | ||
| } | ||
|
|
||
| @Override | ||
| public void rate(String metricName) { | ||
| // no-op | ||
| } | ||
|
|
||
| @Override | ||
| public void rate(String metricName, int count) { | ||
| // no-op | ||
| } | ||
|
|
||
| public ListenableFuture<Service.State> start() { | ||
| delegate.startAsync(); | ||
| return Futures.immediateFuture(Service.State.RUNNING); | ||
| } | ||
|
|
||
| public ListenableFuture<Service.State> stop() { | ||
| delegate.stopAsync(); | ||
| return Futures.immediateFuture(Service.State.TERMINATED); | ||
| } | ||
|
|
||
| public Service startAsync() { | ||
| try { | ||
| delegate.getClass().getMethod("startAsync").invoke(delegate); | ||
| } catch (Exception e) { | ||
| try { | ||
| delegate.getClass().getMethod("start").invoke(delegate); | ||
| } catch (Exception ex) { | ||
| throw new RuntimeException(ex); | ||
| } | ||
| } | ||
| return this; | ||
| } | ||
|
|
||
| public Service stopAsync() { | ||
| delegate.stopAsync(); | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public void awaitRunning() { | ||
| delegate.awaitRunning(); | ||
| } | ||
|
|
||
| @Override | ||
| public void awaitRunning(long timeout, TimeUnit unit) throws TimeoutException { | ||
| delegate.awaitRunning(timeout, unit); | ||
| } | ||
|
|
||
| @Override | ||
| public void awaitTerminated() { | ||
| delegate.awaitTerminated(); | ||
| } | ||
|
|
||
| @Override | ||
| public void awaitTerminated(long timeout, TimeUnit unit) throws TimeoutException { | ||
| delegate.awaitTerminated(timeout, unit); | ||
| } | ||
|
|
||
| @Override | ||
| public Service.State state() { | ||
| return delegate.state(); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isRunning() { | ||
| return delegate.isRunning(); | ||
| } | ||
|
|
||
| @Override | ||
| public Throwable failureCause() { | ||
| return delegate.failureCause(); | ||
| } | ||
|
|
||
| @Override | ||
| public void addListener(Service.Listener listener, Executor executor) { | ||
| delegate.addListener(listener, executor); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.