Repository navigation
fix: drop missing image pull secrets from app store templates - #189
Merged
hsluoyz merged 2 commits intoOct 31, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seventeen sealos catalog templates, including Chrome, Excalidraw, Affine and Immich, name an
imagePullSecretthat Sealos would create and CasOS never does. Kubelet then warnsFailedToRetrieveImagePullSecretand may skip the pull.When a market template is applied, CasOS now drops pull secrets that are not in the namespace, the same way it already drops an Ingress class this cluster does not run. A secret that does exist, or that the template itself creates earlier in the same apply, is kept. If the namespace cannot be listed, the template is left unchanged.
Verification
go build ./...,go vet ./...,go test ./controllers/ -run TestStripMissingImagePullSecrets,go test ./i18n/ -run TestDeduplicateexcalidraw(it shipsimagePullSecrets: [{name: ${{ defaults.app_name }}}]and no matching Secret). The Deployment and Pod had noimagePullSecrets; the app became Ready;http://excalidraw-*.localhost:20080returned 200 with titleExcalidraw | Hand-drawn look & feel • Collaborative • Secure; uninstall removed the pods.Fix: #165