Add an ultimate label alias, global and per-Triangle - #1351
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): 50.0% fully typed (1 / 2)
Patch symbol details
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1351 +/- ##
==========================================
+ Coverage 91.76% 91.78% +0.02%
==========================================
Files 96 96
Lines 5475 5490 +15
Branches 706 708 +2
==========================================
+ Hits 5024 5039 +15
Misses 327 327
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
saw @henrydingliu's note on #1345 - i built this to the spec genedan gave there, so no attachment to it either way. happy to close if the team lands on not wanting it. |
Adds
ULT_LABELas a global option plus a per-Triangleult_labelthat overrides it, as discussed on the issue.The alias is applied at display time only -
_repr_format, which__repr__,_repr_html_andto_frameall go through - soddimsand.developmentkeep theULT_VAL/9999 sentinel and nothing downstream changes. That matters for things likeutility_functions.py's run-off filter, which string-compares development labels against a valuation date.It covers the 9999 development-lag case too, e.g.
full_expectation_ends[..., 132, 'Ultimate'].I left the default as
Noneso nothing changes unless you opt in - happy to default it to"Ultimate"if that's the[BRK]you had in mind, it's a one-line change.pytest chainladdergives 1142 passed. The 2 remaining failures aretest_heatmap_render, which fails the same way on a clean checkout here (no IPython in my venv).Closes #1345.