chore(docs): format Friedland Chapter 8 notebook with ruff (#1341) - #1344
Open
priyam0k wants to merge 1 commit into
Open
chore(docs): format Friedland Chapter 8 notebook with ruff (#1341)#1344priyam0k wants to merge 1 commit into
priyam0k wants to merge 1 commit into
Conversation
priyam0k
requested review from
genedan,
henrydingliu and
kennethshsu
as code owners
September 11, 2026 07:29
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
priyam0k
marked this pull request as draft
September 11, 2026 07:32
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1344 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 96 96
Lines 5475 5475
Branches 706 706
=======================================
Hits 5024 5024
Misses 327 327
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
priyam0k
marked this pull request as ready for review
September 12, 2026 13:51
Member
|
assigning to @kennethshsu as he OG'd chapter 8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related GitHub Issue(s)
Additional Context for Reviewers
All pre-commit ruff checks pass cleanly and all notebook cells run and pass locally.
Checklist
Note
Low Risk
Documentation-only notebook formatting with no application or library code changes.
Overview
Applies ruff format to
docs/friedland/chapter_8.ipynbso Chapter 8 matches the formatting style used for the other Friedland documentation notebooks. This is a style-only change to notebook code cells (whitespace, line breaks, quoting); exhibit logic and reconciliation asserts are unchanged.Fixes #1341.
Reviewed by Cursor Bugbot for commit 5e044a5. Bugbot is set up for automated code reviews on this repo. Configure here.