chore(docs): resolve ruff lint and format in Friedland Ch. 7 Part 2 (#1216) - #1340
chore(docs): resolve ruff lint and format in Friedland Ch. 7 Part 2 (#1216)#1340priyam0k wants to merge 3 commits into
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1340 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 96 96
Lines 5475 5475
Branches 706 706
=======================================
Hits 5024 5024
Misses 327 327
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
a198cd8 to
29c4e96
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 81459bd. Configure here.
| # See https://jupyterbook.org/content/execute.html | ||
| execute: | ||
| execute_notebooks: force | ||
| timeout: 180 |
There was a problem hiding this comment.
what happens when something times out?
There was a problem hiding this comment.
I think that screenshot with the KeyboardInterrupt is actually what happens when a cell times out
Jupyter Book kills any cell that takes longer than 30s. On RTD's fresh runner, building the font cache took just over 30s, so it interrupted the cell and skipped the rest of the notebook.
Upping the timeout to 180s gives it a safe buffer, and pre-warming the cache in prep_sphinx_conf.py fixes the slow cold start.


Summary of Changes
Related GitHub Issue(s)
Additional Context for Reviewers
All pre-commit ruff checks pass cleanly and all notebook cells run and pass locally.
Checklist
Note
Low Risk
Documentation and lint/format only; no library API or runtime behavior changes beyond longer doc CI notebook timeouts.
Overview
Brings Friedland Chapter 7 Part 2 in line with ruff by renaming exhibit helpers to lowercase (
ex3sht10,ex4sht1,ex4sht6, etc.) and reformatting notebook cells, then drops that notebook frompyproject.tomlper-file-ignores for N802.Docs build reliability gets a bump: notebook execution timeout rises from 30s to 180s in
_config.ymlandconf.py, andprep_sphinx_conf.pypre-warms the matplotlib font cache on fresh runners.conf.pyalso picks up quote/style reflow from regeneration;prep_sphinx_conf.pyuses a looser_DOCS_EXT_DIRmarker so re-runs stay idempotent.Reviewed by Cursor Bugbot for commit 36568df. Bugbot is set up for automated code reviews on this repo. Configure here.