[BUG] Missing sp.repeat

[henrydingliu]

Are you on the latest chainladder version?

• Yes, this bug occurs on the latest version.

Describe the bug in words

xp.repeat is called in half a dozen modules in the repo, which is a huge joke because so far only the np path is used (mostly thanks to DevelopmentBase._set_fit_groups). We know this because repeat was only added to sparse in 0.18; however our unittests are currently running on sparse 0.17.

How can the bug be reproduced?

N/A

What is the expected behavior?

N/A

Would you be willing to contribute this ticket?

• Yes, absolutely!
• Yes, but I would like some help.
• No.

[henrydingliu]

@kennethshsu @genedan @priyam0k i'd like your preference between two options

• Plan A: pin sparse to >=0.18
  • we'd also need to abandon python 3.10 support, as sparse 0.18 does not support python 3.10
• Plan B: copy sparse implementation of repeat into our chainladder.utils.sparse

[genedan]

I think we could go with Plan A. Python 3.10 is due to reach EOL very soon. If you're okay with timing the next release past Oct 31, we could just drop it.

[kennethshsu]

I am not super knowledgable here so don't take my opinion as the same weight as others, but I like plan A better too.

I am pro supporting the smallest set of versions possible so make our lives easier.

[kennethshsu]

@henrydingliu what's your preference/recommendation?

[henrydingliu]

@henrydingliu what's your preference/recommendation?

I'm biased since I approved #1315, i.e. already gave my consent to getting a Python 3.10 drop notice. so i have a vested interest to try and avoid that issue being logged.

@priyam0k for your awareness, 3.10 reaches EOL on 10/31, i.e. less than 60 days.

I think as a compromise, let's get 0.10.1 released within the next week without touching this issue. then whenever 1.0.0 or 0.11.0 comes, it will be after the EOL for 3.10. Even if some corporate IT lags behind by a bit, users still have 0.10.1.

[kennethshsu]

If someone is staying on very old python versions, they must have a reason for it, and if they aren't upgrading, they must also aren't complaining about missing newer features.

Good with pushing out 0.10.1 next week. Any final PRs or issues we want to close out? Should we start a new thread on this? Or not needed?

[henrydingliu]

Any final PRs or issues we want to close out?

can someone just approve the PR template PR so it can be merged? that's about the only one.

Should we start a new thread on this? Or not needed?

raising an issue to raise awareness is always good. in case anyone else had a burning PR