Skip to content

fix(keychain): route card purchases through credits - #2660

Closed
joystick-gg[bot] wants to merge 3 commits into
mainfrom
centaur/route-credit-card-through-credits-20260721-153843
Closed

joystick-gg[bot] wants to merge 3 commits into
mainfrom
centaur/route-credit-card-through-credits-20260721-153843

Conversation

@joystick-gg

@joystick-gg joystick-gg Bot commented Jul 21, 2026 •

Copy link
Copy Markdown
Contributor

Defaults to the Credits rail whenever the existing balance covers the starter-pack purchase, even when Credit Card was previously remembered. When credits are insufficient and Credit Card is selected, routes through the existing credits deposit flow and automatically resumes the bundle purchase after settlement. Replaces the direct Coinflow starter-pack total with the authoritative credits quote and renders the payment unit as USD, with regression coverage for preference resolution, card routing, shortfall rounding, and minimum deposits. Validated with keychain lint, formatting, production build, 757 passing tests, and a Playwright-rendered Storybook check; the repository-wide pre-commit build's live GraphQL codegen timed out against api.cartridge.gg, so the commits used the already validated checked-in generated schema.

Prompted by: tarrence

@vercel

vercel Bot commented Jul 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Jul 21, 2026 6:41pm
controller-ui Ready Ready Preview Jul 21, 2026 6:41pm
keychain Ready Ready Preview Jul 21, 2026 6:41pm
keychain-storybook Ready Ready Preview Jul 21, 2026 6:41pm

Request Review

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 24.67532% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.78%. Comparing base (f19fb35) to head (1c00856).
⚠️ Report is 54 commits behind head on main.

Files with missing lines Patch % Lines
...s/keychain/src/components/purchase/review/cost.tsx 0.00% 34 Missing ⚠️
...src/components/purchase/checkout/onchain/index.tsx 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2660      +/-   ##
==========================================
+ Coverage   23.68%   28.78%   +5.09%     
==========================================
  Files         352      378      +26     
  Lines       42485    48053    +5568     
  Branches     1370     2088     +718     
==========================================
+ Hits        10064    13830    +3766     
- Misses      32398    34180    +1782     
- Partials       23       43      +20     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joystick-gg

joystick-gg Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #2661. The original branch name exceeded Vercel alias limits, so the example and keychain received different project-specific hashes; the replacement uses a short branch and has been verified to embed the matching keychain preview iframe.

@joystick-gg joystick-gg Bot closed this Jul 21, 2026

This branch was successfully deployed

4 active deployments
Preview – keychain-storybook — 4f910bb4 Deployed Jul 21, 2026 by vercel[bot]
Preview – controller-example-next — 4f910bb4 Deployed Jul 21, 2026 by vercel[bot]
Preview – controller-ui — 4f910bb4 Deployed Jul 21, 2026 by vercel[bot]
Preview – keychain — 4f910bb4 Deployed Jul 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants